Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60507] Eventually cancel node blocks in anomalous status #299

Merged
merged 3 commits into from Apr 14, 2023
Merged

[JENKINS-60507] Eventually cancel node blocks in anomalous status #299

merged 3 commits into from Apr 14, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 7, 2023

Observed during a build of jenkinsci/bom#1832. @dduportal et al., any interest in testing this?

@jglick jglick added the bug label Mar 7, 2023
@jglick jglick requested a review from a team March 7, 2023 19:42
@jglick jglick marked this pull request as draft March 7, 2023 20:11
@jglick
Copy link
Member Author

jglick commented Mar 7, 2023

Probably too aggressive, trying to tune this a bit. Without knowing how to reproduce the original problem I can only guess.

@jglick jglick marked this pull request as ready for review March 7, 2023 21:08
@dduportal
Copy link
Contributor

Observed during a build of jenkinsci/bom#1832. @dduportal et al., any interest in testing this?

Absolutely interested !

jglick added a commit to jglick/docker-jenkins-weekly that referenced this pull request Mar 9, 2023
@jglick
Pick up jenkinsci/workflow-durable-task-step-plugin#299
53cd6f3
@jglick jglick mentioned this pull request Mar 9, 2023
Merged
lemeurherve added a commit to jenkins-infra/docker-jenkins-weekly that referenced this pull request Mar 13, 2023
@jglick @lemeurherve
Pick up jenkinsci/workflow-durable-task-step-plugin#299 (#1125)
cc324e6 
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
@dduportal
Copy link
Contributor

@jglick just installed on ci.jenkins:

Capture d’écran 2023-03-24 à 13 30 33

Let's check how ti behaves.
Any particular point to check?

@jglick
Copy link
Member Author

jglick commented Mar 24, 2023

Any particular point to check?

That there are no builds marked aborted improperly. If this works, it should automatically clean up certain cases of builds which were actually corrupted (letting them complete normally if retry is used).

@jglick jglick mentioned this pull request Mar 28, 2023
Closed
@jglick
Copy link
Member Author

jglick commented Apr 13, 2023

I guess there have been no obvious problems arising from this? So I think it could be merged.

@dduportal
Copy link
Contributor

I guess there have been no obvious problems arising from this? So I think it could be merged.

Confirmed. Sorry for the delay in answer, but no issue: go go go

@car-roll car-roll merged commit ee71f67 into jenkinsci:master Apr 14, 2023
13 checks passed
smerle33 added a commit to jenkins-infra/docker-jenkins-weekly that referenced this pull request Apr 14, 2023
@smerle33
chore(plugin workflow-durable-task-step): remove incremental as PR #299…
8df3307 
… is merged)

as per jenkinsci/workflow-durable-task-step-plugin#299
@smerle33 smerle33 mentioned this pull request Apr 14, 2023
Merged
dduportal pushed a commit to jenkins-infra/docker-jenkins-weekly that referenced this pull request Apr 14, 2023
@smerle33
chore(plugin workflow-durable-task-step): remove incremental as PR #299…
5f070fd 
… is merged) (#1183)

as per jenkinsci/workflow-durable-task-step-plugin#299
@jglick jglick deleted the anomaly-JENKINS-60507 branch April 14, 2023 15:03
@jglick jglick mentioned this pull request Apr 24, 2023
Closed
6 tasks
@jglick jglick mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@car-roll car-roll car-roll approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@jglick @dduportal @car-roll