-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-43353] Option to disable concurrent builds by aborting previous ones #200
[JENKINS-43353] Option to disable concurrent builds by aborting previous ones #200
Conversation
…r every build to finish
https://github.com/jenkinsci/jenkins/blob/794770f7b27b323a42c07ae03d2cb64a0acb5a8d/core/src/main/java/hudson/model/Run.java#L352 sounds incorrect for `WorkflowRun`, which can survive restart. https://github.com/jenkinsci/jenkins/blob/794770f7b27b323a42c07ae03d2cb64a0acb5a8d/core/src/main/java/hudson/model/Run.java#L910-L913 looks like it could break lazy-loading in some cases. Anyway for purposes of this feature we really only care about the previous build: there should not be _intermediate_ completed builds once this mode takes effect.
...va/org/jenkinsci/plugins/workflow/job/properties/DisableConcurrentBuildsJobPropertyTest.java
Outdated
Show resolved
Hide resolved
@cathychan & @jtnord point out that when introducing this option for the first time, say to replace the |
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jenkinsci/workflow-job-plugin#200 Removes the need to use our own convoluted implementation: https://github.com/status-im/status-jenkins-lib/blob/17c1d0ea/vars/jenkins.groovy#L6-L27 Signed-off-by: Jakub Sokołowski <jakub@status.im>
JENKINS-43353, more straightforward and efficient than using the previous hack
Can be configured via GUI (for standalone Pipelines) or as code