This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
[JENKINS-29326] Don't add duplicate BuildData (downstream) #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked as @ignore until jenkinsci/git-plugin#372 is merged and released, at which point we'll need to bump the git plugin version as well.
|
cc @reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
reopening for a new run... |
|
Stupid nio channel failures! Unrelated, obviously. |
| @@ -162,4 +166,30 @@ | |||
| assertFalse(iterator.hasNext()); | |||
| } | |||
|
|
|||
| // This test is currently disabled until the fix for JENKINS-29326 is released | |||
| // in the git plugin, in 2.4.1 or later. | |||
There was a problem hiding this comment.
You can use this text as the @Ignore value parameter I think.
|
🐝 |
| @@ -162,4 +166,28 @@ | |||
| assertFalse(iterator.hasNext()); | |||
| } | |||
|
|
|||
| @Ignore("This test is currently disabled until the fix for JENKINS-29326 is released in the git plugin 2.4.1 or later.") | |||
| " }\n" + | ||
| "}")); | ||
| WorkflowRun b = r.assertBuildStatusSuccess(p.scheduleBuild2(0)); | ||
| assertEquals(1, b.getActions(BuildData.class).size()); |
jglick
changed the title
|
🐝 |
abayer
added a commit
that referenced
this pull request
Dec 16, 2015
[JENKINS-29326] Don't add duplicate BuildData (downstream)
|
Now see if you can revert jenkinsci/bitbucket-plugin#20. @fbelzunc wrote no test so it will be a little work to verify. |
jglick
added a commit
that referenced
this pull request
Jan 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as @ignore until
jenkinsci/git-plugin#372 is merged and
released, at which point we'll need to bump the git plugin version as well.