[JENKINS-59560] Delete empty changelog files to avoid issues in WorkflowRun.onCheckout #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
approved these changes
Jan 14, 2020
dwnusbaum
changed the title
dwnusbaum
changed the title
car-roll
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-57918 and JENKINS-59560.
Tries to prevent issues where the SCM does not write anything to the changelog file, not even the headers for an empty XML file, so it doesn't cause problems later on in
WorkflowRun.onCheckout.I haven't had much luck trying to create automated tests in this plugin in the past, but we really need some to prevent regressions like this. We probably shouldn't merge this without any tests.