-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-51170] Enable the usage of the StepEnvironmentContributor extension point #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-8ch
changed the title
Enable the usage of the StepEnvironmentContributor extension point
[JENKINS-51170] Enable the usage of the StepEnvironmentContributor extension point
Jun 1, 2018
jglick
requested changes
Jun 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small mistake.
src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java
Outdated
Show resolved
Hide resolved
t-8ch
force-pushed
the
step-environment-contributor
branch
from
June 7, 2018 07:51
3f436d0
to
d09828a
Compare
Implemented. |
t-8ch
force-pushed
the
step-environment-contributor
branch
from
January 15, 2019 15:52
d09828a
to
18ad181
Compare
dwnusbaum
previously requested changes
Jan 16, 2019
src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java
Outdated
Show resolved
Hide resolved
t-8ch
force-pushed
the
step-environment-contributor
branch
from
January 18, 2019 09:27
18ad181
to
2e9775a
Compare
Support the new StepEnvironmentContributor hook introduced in jenkinsci/workflow-step-api-plugin#36.
t-8ch
force-pushed
the
step-environment-contributor
branch
from
January 18, 2019 09:30
2e9775a
to
a7efba9
Compare
jglick
approved these changes
Jan 18, 2019
src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java
Show resolved
Hide resolved
dwnusbaum
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #60 and jenkinsci/workflow-step-api-plugin#36