Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly call processAnnotations #84

Merged
merged 1 commit into from Oct 9, 2020
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 8, 2020

Compatibility with jenkinsci/jenkins#4944.

jglick added a commit to jglick/jep that referenced this pull request Oct 8, 2020
@nfalco79
Copy link
Member

nfalco79 commented Oct 9, 2020

you can rebase

@jglick
Copy link
Member Author

jglick commented Oct 9, 2020

Note that when merging you can choose a rebase option, without needing action from the PR author. Or if you want all PRs to be tested against latest master, just set up branch restrictions.

@nfalco79
Copy link
Member

nfalco79 commented Oct 9, 2020

Note that when merging you can choose a rebase option, without needing action from the PR author.

I know I want be sure the build passes.

just set up branch restrictions.

are you speaking about github settings (I have not admin role) or some option in the buildPlugin library (I did find any branch or restriction option in main documentation)?

@nfalco79 nfalco79 merged commit 8489a49 into jenkinsci:master Oct 9, 2020
@jglick
Copy link
Member Author

jglick commented Oct 9, 2020

I have not admin role

Ah, never mind then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants