New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail for me #170

Open
trestletech opened this Issue Sep 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@trestletech

trestletech commented Sep 27, 2015

Depending on how I test the package, I get different failures. testthat::test_package produces a smaller set. devtools::test() fails all but the last authorization test, etc.

At the very least, it looks like the expectations around user_info in test-auth.R will be problematic.

Additionally, access to the private sheet in test-consume-data-private.R is problematic for anyone for whom you haven't granted access.

IMHO it's understandable if this particular package requires some additional love to get the tests working. But a "Development" section in the readme that documents what needs to be done would be neat.

And/or if you're willing to be proprietary, checking in the .Rproj file with the build flags you use would be convenient.

@jennybc

This comment has been minimized.

Owner

jennybc commented Sep 27, 2015

You're right ... it's definitely not set up for people other than me to run the tests. You're the first person who has wanted to. Will work on it.

Here's the build section of .Rproj:

BuildType: Package
PackageUseDevtools: Yes
PackageInstallArgs: --no-multiarch --with-keep.source --library="/Users/jenny/resources/R/library" --html
PackageRoxygenize: rd,namespace,vignette

I had not committed that because the library is hard-wired to something specific to me and I didn't know if it was worse to provide or not?

@trestletech

This comment has been minimized.

trestletech commented Sep 27, 2015

Oh, ok. I didn't know if you were doing anything fancy in CMD check. May not be worth checking in, then.

Obviously no rush on this. I was just going to whittle away at the get0/R 3.2 issue while I was downloading R but I wanted to make sure I wasn't breaking your package as I went.

jennybc added a commit that referenced this issue Mar 14, 2016

use functions for built-in example sheets in the tests
also represents a very small step towards resolving #170

jennybc added a commit that referenced this issue Mar 14, 2016

use functions for built-in example sheets in the tests
also represents a very small step towards resolving #170

jennybc added a commit that referenced this issue Mar 14, 2016

use functions for built-in example sheets in the tests
also represents a very small step towards resolving #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment