Switch to xml2 #102
Switch to xml2 #102
Conversation
jzhaoo
commented
Apr 15, 2015
jzhaoo
commented
- depend on xml2 for parsing and handling response of GET, big speed boost for consume functions
| after_success: | ||
| git log -n 1 --format=%B | grep -iq "covr"; if [ $? -eq 0 ]; then echo "Checking test coverage with covr"; Rscript -e 'library(covr);coveralls()'; fi | ||
|
|
||
| after_success: git log -n 1 --format=%B | grep -iq "covr"; if [ $? -eq 0 ]; then echo |
There was a problem hiding this comment.
Did you mean to introduce a line break here? The ugly long line was originally intentional but maybe you've verified it still works WITH the line break? If not, please put this back the way it was and make a commit including [covr] both to check this is in working order and to update the test coverage info.
There was a problem hiding this comment.
The line break was introduced when the decryption command was added to .travis.yml and it doesn't seem to cause any trouble as shown by the passing build ... Change it back anyways?
There was a problem hiding this comment.
But we won't know if it causes trouble unless that gets executed, i.e. when the commit message includes [covr]. This is conditional on the commit msg.
…inside {} in pipelines; code style
Conflicts: R/consume-data.R
Conflicts: .travis.yml R/consume-data.R R/register.R
probably not ...
this was the expected outcome for the record, we aren't waiting/hoping for binary xml2 to appear on cran but rather here: https://launchpad.net/~marutter/+archive/ubuntu/c2d4u
waiting for this merged PR to show up on cran: tidyverse/magrittr#61
switch to xml2 for *reading* XML
