~~Addin~~ extremely slow (perhaps just windows?) - add some kind of "busy" feedback?

[daattali]

I copied the following text to clipboard:

foo <- "bar"

Then opened the addin and clicked on "Render". It takes 4-6 seconds until the modal shows up. I have no idea if something is happening or not. If I click the render button again any time in those 5 seconds, it errors out. Would be good to either show a "working" message, or just disable the render button after pressing it

rstudio 1.1.39

[jennybc]

Can you compare to doing the same with just reprex()? I also created a branch with no modal but just the message, as you and I did (https://github.com/jennybc/reprex/tree/no-modal). Would you try that too? Where could it be spending 4-6 seconds?!

[daattali]

It's not because of the modal, it takes several seconds if I just run `reprex()`

…

--- R-Shiny Consultant http://deanattali.com/shiny

On 16 January 2017 at 08:08, Jennifer (Jenny) Bryan < ***@***.***> wrote: Can you compare to doing the same with just reprex()? I also created a branch with no modal but just the message, as you and I did ( https://github.com/jennybc/reprex/tree/no-modal). Would you try that too? Where could it be spending 4-6 seconds?! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6IFI-u0X2VU7e0ebySHhMTCbYr9z3Jks5rS2uygaJpZM4LkPnw> .

[jennybc]

So then it has nothing to do with the addin at all, right?

[daattali]

Correct. Did not know that initially. But the problem does extend into the addin in the sense that it's easy to click the button multiple times because you don't know it's processing

…

On Jan 16, 2017 1:34 PM, "Jennifer (Jenny) Bryan" ***@***.***> wrote: So then it has nothing to do with the addin at all, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6IFDeAhroemNS8FAISx8Q65-5TMd2tks5rS7g4gaJpZM4LkPnw> .

[jennybc]

Thanks to #85 there is at least a spinner now. 🙂

[daattali]

Woah this comment/commit is a gold mine! New profile picture, callr, install-github.me - so many secrets