Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #1671 #1672

Merged
merged 1 commit into from Jan 19, 2022
Merged

fix for #1671 #1672

merged 1 commit into from Jan 19, 2022

Conversation

jp112sdl
Copy link
Contributor

Description

  • renamed "allDevsList" to "allBidCosDevsList" to clarify, that there are only BidCos devices listed.
  • added a check, if this list is empty

Related Issue

#1671

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

Verification Process

Release Notes

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

@jp112sdl
- renamed "allDevsList" to "allBidCosDevsList" to clarify, that there…
fbf5c67 
… are only BidCos devices listed.

- added a check, if this list is empty

fixes jens-maus#1671
@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component labels Jan 19, 2022
@jens-maus jens-maus added this to the next release milestone Jan 19, 2022
@jens-maus jens-maus linked an issue Jan 19, 2022 that may be closed by this pull request
Ohne Funkmodul Geräteliste und Filter bei Gewerke und Räume leer #1671
Closed
@jens-maus jens-maus merged commit 89c44d5 into jens-maus:master Jan 19, 2022
@jp112sdl jp112sdl deleted the fix_EmptyAlldevsArray branch January 25, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
None yet
Milestone
3.61.7.20220226
Development

Successfully merging this pull request may close these issues.

Ohne Funkmodul Geräteliste und Filter bei Gewerke und Räume leer
2 participants
@jp112sdl @jens-maus