PatchWork Reports InitSemaphore "Structure Is Not Cleared"

[tygre-chingu]

Hi!

I run PatchWork on my Amiga and it reports the issue "Severity 2: structure is not cleared" in relation to exec.library InitSemphore(). I think that this issue happens in SSL_read().

You can reproduce this issue by running PatchWork NOPERMIT MINOS=40 LEVEL=1 SMALL and, for example, IBrowse. In IBrowse, access a HTTP Web site (no "hits") and a HTTPS Web site (many "hits").

Thanks! 👍

[Futaura]

How bizarre! I'm not sure I ever read that part of the autodoc - it is still there in OS4. Normally, the OS Init*() functions would initialize structures completely and not require the application to clear it themselves first. Usually, it is not a problem as InitSemaphore() is called on some global variable that would have been cleared by the OS at load time, but this won't apply to

amissl/openssl/crypto/threads_amissl.c

Line 36 in a73caa1

#define ALLOCSEMAPHORE(sem, type) if ((sem = (type *)OPENSSL_malloc(sizeof(type))) != NULL) InitSemaphore((struct SignalSemaphore *)sem)

which is easily fixed, but I need to check the other calls to InitSemaphore() too

[tygre-chingu]

Thanks Futaura :-)

[Futaura]

This was indeed only triggered by the one line of code mentioned earlier and even better it required just one character to be changed to fix it. I like these kind of fixes :-). For all the other instances, the semaphore memory will already be clear and I've tested the fix with PatchWork and those error reports are now gone. I was surprised to see how many times locks were being allocated - perhaps an optimisation to look into at some point.

It also only affected OS3 as the semaphore is instead allocated and initialised by AllocSysObjectTags() on OS4.

[tygre-chingu]

Wonderful, thanks! 👍

[tygre-chingu]

Just to confirm that the "hits" disappeared with AmiSSL v5.7 :-)