correct full date repeating RRule and Luxon disagree on date format (utc vs Local) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old name, lookup current name
…jens-maus-master
|
Sorry, but your PR is showing way to much commits from a different/old PR. Please rebase your master branch to the latest master branch of node-ical, the generate a dedicated branch and do not send in PR based on your master branch which obviously is/was not on the latest HEAD of node-ical. This is not how PRs should be submitted. |
|
See the following link for a nice walk-through/tutorial on how to deal with PRs: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github Take special note on the section on working on a dedicated branch before submitting a PR and also how to update the branch over time in case the upstream (here node-ical) has checked in things in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36
now that we store dates in utc format, full date repeating east of UTC are offset wrong for luxon