Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in snippets.json #10

Merged
merged 8 commits into from
Apr 3, 2018
Merged

Fix issues in snippets.json #10

merged 8 commits into from
Apr 3, 2018

Conversation

matthewpizza
Copy link
Contributor

Hi! Thanks for creating this extension. This PR is to resolve a couple issues with snippets:

  • Removes extra escaping that inserted \ with the snippet (fixes remove Character \ #6)
  • Fixes the right delimiter in the literal, block, and extends snippets
  • Removes preceding and proceeding new lines \n
  • Removes the "scope" property which the linter didn’t like
  • Uses \t for all indenting

}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the newline?

Copy link
Owner

@jens1o jens1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a simple style issue. :) Thank you!

@jens1o jens1o added this to the Next milestone Apr 3, 2018
@jens1o
Copy link
Owner

jens1o commented Apr 3, 2018

Just tested it, it's working perfect! :)

@jens1o jens1o merged commit e6b6be7 into jens1o:master Apr 3, 2018
@jens1o
Copy link
Owner

jens1o commented Apr 3, 2018

Thank you!

@matthewpizza
Copy link
Contributor Author

Thanks for merging!

@jens1o
Copy link
Owner

jens1o commented Apr 3, 2018

The version has been published! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Character \
2 participants