Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 to the CI matrix #103

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Add Ruby 3.1 to the CI matrix #103

merged 1 commit into from
Dec 12, 2022

Conversation

petergoldstein
Copy link
Contributor

In addition to the necessary changes to the workflow.yml - added 3.1 and excluding unsupported ActiveRecord/Ruby combinations, the following changes were made:

  1. Updated gemfiles to modern versions of rake and rspec - this was necessary to get specs running. There are some deprecation warnings, but everything runs green
  2. Use YAML safe_load with an aliases true argument - As Psych 4.0+ now calls safe_load for load, we make this call explicit and add the necessary aliases argument for it to pass.

Update gemfiles to modern versions of rake and rspec

Use YAML safe_load
@petergoldstein
Copy link
Contributor Author

@jenseng jenseng merged commit 0e54993 into jenseng:master Dec 12, 2022
@jenseng
Copy link
Owner

jenseng commented Dec 12, 2022

Thanks @petergoldstein!

@petergoldstein
Copy link
Contributor Author

@jenseng As Ruby 3.2 is just about to come out, it may be worth revisiting the supported matrix, trimming some old versions, and adding 3.2 preemptively (making any necessary changes to the code base)

@jenseng
Copy link
Owner

jenseng commented Dec 12, 2022

Good call, thanks @petergoldstein 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants