nowrap option for PostgreSQL #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 15, 2014 13:21
… triggers/functions can be executed directly (e.g. tsvector_update_trigger)
|
From a quick glance, this looks great. I'll dig into it some more later and merge it in (or let you know if any tweaks are needed). Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered a use case where I needed to execute an existing trigger (
tsvector_update_trigger) but this was not compatible with how the PostgreSQL triggers are declared, as others have found. Thisnowrapchainable method sets an option to indicate that theraw_actionshould be executed directly, rather than being wrapped in aCREATE FUNCTION.Wrapping the
raw_actiononly seems to happen to PostgreSQL, and it looks like this was to enablesecurityand legacy support forwhere. I have added appropriate warnings for when these options are set in conjunction withnowrap.