Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running tests fails on Windows #28

Closed
Download opened this issue Oct 31, 2016 · 0 comments
Closed

Running tests fails on Windows #28

Download opened this issue Oct 31, 2016 · 0 comments

Comments

@Download
Copy link
Contributor 

c:\ws\react-i18nliner> npm test

> react-i18nliner@0.1.0 test c:\ws\react-i18nliner
> eslint . && node_modules/.bin/jest

'node_modules' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! Test failed.  See above for more details.

I'll prepare a PR to fix this.
Download added a commit to Download/preact-i18nline that referenced this issue Oct 31, 2016
@Download
Fix build on Windows
8a78188 
Removed the node_modules prefix when calling eslint and jest
They are not needed since these libraries are NPM dependencies and NPM knows how to invoke them
See Running tests fails on Windows jenseng#28
@Download Download mentioned this issue Oct 31, 2016
Merged
@jenseng jenseng closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jenseng @Download