Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to install without passlib support? #68

Closed
fekblom opened this issue Jun 21, 2014 · 5 comments
Closed

Impossible to install without passlib support? #68

fekblom opened this issue Jun 21, 2014 · 5 comments

Comments

@fekblom
Copy link
Contributor

fekblom commented Jun 21, 2014

When answering 'no' on the "Do you want to install the 'passlib' module?" question I later get the following exception after selecting the access scheme.

How will Critic be accessed? [http] http
FAILED: installation.config.prepare()
Traceback (most recent call last):
  File "install.py", line 128, in <module>
    if hasattr(module, "prepare") and not module.prepare("install", arguments, data):
  File "/path/to/critic/installation/config.py", line 511, in prepare
    calibrate_minimum_rounds()
  File "/path/to/critic/installation/config.py", line 112, in calibrate_minimum_rounds
    import passlib.context
ImportError: No module named passlib.context

ERROR: Installation aborted.
@jensl
Copy link
Owner

jensl commented Jun 21, 2014

Yeah, passlib is required. The installation ought to abort if you opt not to install it.

@jensl
Copy link
Owner

jensl commented Jun 21, 2014

Hmm. Actually, it's more complicated than that. Passlib is required unless you later choose to let the web server authenticate users. That later choice ought to be disabled if you chose not to install passlib.

@fekblom
Copy link
Contributor Author

fekblom commented Jun 22, 2014

OK, I believe that I did opt for having Apache handle the user authentication. I can do some more investigation (and possibly get back with a fix).

@jensl
Copy link
Owner

jensl commented Jun 22, 2014

Ah. Could be we unconditionally call calibrate_minimum_rounds(). There's no reason to do so when using "host" authentication.

@mo
Copy link
Collaborator

mo commented Jul 7, 2014

Fixed in 07ac591

@mo mo closed this as completed Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants