Skip to content
This repository has been archived by the owner on Jun 9, 2019. It is now read-only.

Regex: Allow "v" in tag name to be optional #18

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Regex: Allow "v" in tag name to be optional #18

merged 2 commits into from
Jun 2, 2016

Conversation

manosim
Copy link
Contributor

@manosim manosim commented May 31, 2016

No description provided.

@manosim
Copy link
Contributor Author

manosim commented May 31, 2016

@jenslind I've found a bug so I think this one is not ready.

Progress: http://jsbin.com/hogopiguci/5/edit?js,console

Update
Looks like this works for both types (with or without v). So Line 92 will be const versionInZipUrl = matchReleaseUrl[matchReleaseUrl.length -1] Opinions?

@jenslind jenslind merged commit 0827995 into jenslind:master Jun 2, 2016
@jenslind
Copy link
Owner

jenslind commented Jun 2, 2016

Thanks! Released in 2.0.3.

@manosim manosim deleted the fix-regex branch June 2, 2016 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants