Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable draggable flag on nodes #4

Closed
wants to merge 6 commits into from
Closed

enable draggable flag on nodes #4

wants to merge 6 commits into from

Conversation

jobergner
Copy link
Collaborator

No description provided.

@gorillamoe
Copy link
Collaborator

Hey @Java-Jonas,

I hope you're doing fine today.

I'm sorry, but we can't merge this, because it changes one of the files in the dist directory and those files are generated automatically by the build-process.

The changes seem legit, though. Could you migrate these changes over to the affected file(s) in the src directory and commit again, please?

Thanks in advance and have a nice day!

@gorillamoe
Copy link
Collaborator

The updated commits seem okay to me. I would recommend the Maintainer(s) to squash these commits and then merge.

Thanks for your contribution @Java-Jonas !

gorillamoe added a commit that referenced this pull request Feb 9, 2018
This commit adds the `canDrag` method to the `lib/block.tsx`.
It's a squashed commit from this PR: #4

Explicitly these commits here: #4 (commits)
@gorillamoe
Copy link
Collaborator

Hey @Java-Jonas,
I'm happy to say, that I've write access to the upstream repo now.

I squashed these 6 commits into one and merged them into master.

Thanks for your contribution!

@gorillamoe gorillamoe closed this Feb 9, 2018
gorillamoe added a commit that referenced this pull request Feb 9, 2018
This commit adds the `canDrag` method to the `lib/block.tsx`.
It's a squashed commit from this PR: #4

Explicitly these commits here: #4 (commits)
@gorillamoe gorillamoe added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants