fix - package broken due to dependecy code change

[driade]

Hi.

Surely due to this change

serbanghita/Mobile-Detect@ba9281b

the package is broken as we add to "getOperatingSystems" a list of not really mobile ones.

Hope this helps.

cc #207

[driade]

cc @ash-jc-allen/short-url#222

[driade]

A temporary solution for those affected would be sticking mobiledetect/mobiledetectlib to version 2.8.41

composer require mobiledetect/mobiledetectlib 2.8.41

[driade]

Long explanation

This code prints "1" with mobiledetect 2.8.43, and "" with 2.8.41

use Jenssegers\Agent\Agent;

$agent = new Agent();
$agent->setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/537.13+ (KHTML, like Gecko) Version/5.1.7 Safari/534.57.2');
echo $agent->isPhone();

This is due to a change in mobiledetect, that instead of using an internal list of mobile operating systems, uses the function getOperatingSystems().

public static function getOperatingSystems()
{
    return self::$operatingSystems;
}

This function is overriden by jenssegers/agent, which adds a few more operating systems

public static function getOperatingSystems()
{
        return static::mergeRules(
            static::$operatingSystems,
            static::$additionalOperatingSystems
        );
}

These additionalOperatingSystems on jenssen are not mobile ones.

 protected static $additionalOperatingSystems = [
        'Windows' => 'Windows',
        'Windows NT' => 'Windows NT',
        'OS X' => 'Mac OS X',
        'Debian' => 'Debian',
        'Ubuntu' => 'Ubuntu',
        'Macintosh' => 'PPC',
        'OpenBSD' => 'OpenBSD',
        'Linux' => 'Linux',
        'ChromeOS' => 'CrOS',
    ];

[derekmd]

The same issue also exists for the getBrowsers() method override. e.g., any user agent string containing "Firefox" or "Chrome" returns Agent::isMobile() === true and Agent::isDesktop() === false, despite not having a mobile device indicator in the string.

The Agent class getter method overrides would need to be renamed and/or removed.

For this package:

1. 1.x likely just needs to pin composer require mobiledetect/mobiledetectlib:2.8.41 and archive that branch.
2. 2.x could remove the method overrides and upgrade mobiledetect/mobiledetectlib that is currently on v4.

This package hasn't seen maintenance since 2021 so a community initiative is likely needed.

[serbanghita]

today: I'm reverting the change in Mobile Detect, will keep you posted.

[driade]

@serbanghita Thank you very much, this is really appreciated.

[serbanghita]

Should be fixed without intervention to jenssegers/agent

#207 (comment)

[driade]

Thanks again @serbanghita , I'm closing this pull request