Skip to content

Commit

Permalink
馃毀 Ditch php 5.6
Browse files Browse the repository at this point in the history
  • Loading branch information
@jenssegers
jenssegers committed May 25, 2019
1 parent 9bdc785 commit cf1d8ef
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
language: php

php:
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm
- 7.3

sudo: false

Expand All @@ -18,4 +17,4 @@ script:
- ./vendor/bin/phpunit --coverage-clover build/logs/clover.xml

after_success:
- sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then php vendor/bin/coveralls -v; fi;'
- php vendor/bin/coveralls -v

2 comments on commit cf1d8ef

@CSchloegel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occam's Razor, why ditch 5.6? Doesn't seem like you've made any changes that would require it.

@visavi
Copy link

@visavi visavi commented on cf1d8ef Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen

That's right, the design uses the type of hint string that was added only in php 7.0

Please sign in to comment.