Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong call to method share #37

Merged
merged 1 commit into from Jul 31, 2019
Merged

Fixed wrong call to method share #37

merged 1 commit into from Jul 31, 2019

Conversation

amoutonbrady
Copy link
Contributor

When calling the method share, the wrong method shared is called on the Factory. This commit aim to fix that.

@amoutonbrady
✏️ Fixed wrong call to method share
f2022bc 
When calling the method `share`, the wrong method `shared` is called on the Factory. This commit aim to fix that.
@amoutonbrady amoutonbrady changed the title ✏️ Fixed wrong call to method share Fixed wrong call to method share Jul 31, 2019
@amoutonbrady amoutonbrady mentioned this pull request Jul 31, 2019
Open
@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.621% when pulling f2022bc on amoutonbrady:master into 8dc7d31 on jenssegers:master.

@jenssegers jenssegers merged commit 34e9f99 into jenssegers:master Jul 31, 2019
@jenssegers
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amoutonbrady @coveralls @jenssegers