Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In German "ago" has to include an "n" at the end #21

Closed
dhardtke opened this issue Jul 1, 2014 · 8 comments
Closed

In German "ago" has to include an "n" at the end #21

dhardtke opened this issue Jul 1, 2014 · 8 comments

Comments

@dhardtke
Copy link

dhardtke commented Jul 1, 2014

Hey guys,

I just started using your package and like it so far, but I noticed a slight issue when using diffForHumans():
"vor 10 Monate" - this is grammatically wrong, it should be:
"vor 10 Monaten"

I fixed it by editing the de.php in the lang folder:

'ago'   => 'vor :timen',
@jenssegers
Copy link
Owner

But if you do this, you would get '1 monatn' when :count is 1?

@jenssegers
Copy link
Owner

I added plural forms for 'ago' etc:

'ago'       => 'vor :time|vor :timen',

Is 'ago' the only one that has the extra 'n'? Or are there others?

@dhardtke
Copy link
Author

dhardtke commented Jul 2, 2014

Yes, it's the only one..

perfect, thank you! :)

@dhardtke
Copy link
Author

dhardtke commented Jul 4, 2014

Okay, it's not perfect yet:

'year' => '1 Jahr|:count Jahre',
    'month' => '1 Monat|:count Monate',
    'week' => '1 Woche|:count Wochen',
    'day' => '1 Tag|:count Tage',
    'hour' => '1 Stunde|:count Stunden',
    'minute' => '1 Minute|:count Minuten',
    'second' => '1 Sekunde|:count Sekunden',

So what I get is "Vor 10 Stundenn" - notice the two 'n's?
mmh.. How can this be fixed?

@jenssegers
Copy link
Owner

That's a difficult one, I really don't see an easy solution for this.

@jenssegers jenssegers reopened this Jul 6, 2014
@jenssegers
Copy link
Owner

Issue #27 seems to be related to this.

@jenssegers
Copy link
Owner

I added custom translations for suffixes in f6b2a3c

This should be correct right?

'year_ago'      => '1 Jahr|:count Jahren',
'month_ago'     => '1 Monat|:count Monaten',
'week_ago'      => '1 Woche|:count Wochen',
'day_ago'       => '1 Tag|:count Tagen',
'hour_ago'      => '1 Stunde|:count Stunden',
'minute_ago'    => '1 Minute|:count Minuten',
'second_ago'    => '1 Sekunde|:count Sekunden',

@dhardtke
Copy link
Author

dhardtke commented Jul 6, 2014

Yes, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants