-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Slovak translation but :count is more complicated in my language #27
Conversation
More complicated in what way? |
let's say that 'minute' => '1 minúta|:count minutes', would become 'minute' => '1 minúta|:count minúty', but if I were to use it with 'before' => ':time before', 'minute' would have to be minútami while counted |
Could you translated the plural forms in the meanwhile? I will try to figure something out on how we could solve this (but it doesn't look that easy). |
One way to tackle this is if we would add additional language lines containing a suffix, like:
These would be optional and would get a higher priority when used with ago and before. |
German also had this problem, and I updated the code to allow for translations in combination with specific suffixes. Check out the german language file: https://github.com/jenssegers/laravel-date/blob/master/src/lang/de/date.php Could you update the Slovak file like that? |
@olso Can you see if you can fix the Slovak translation file? |
It's the same pattern for Czech, Polish and probably all Slavic languages |
what about adding custom behavior for specific languages (for example javascript library Moment.js ) |
How would you implement this? |
For reference, there is a pseudo-port of moment.js to PHP at fightbulc/moment.php - consulting its code may illuminate what @CylonSK is thinking, here, which at a cursory glance seems to indicate supporting Closures as well as strings in language files. |
No description provided.