You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But in Laravel 4 $this->app->version() method doesn't exist at all and will throw a beautiful Call to undefined method Illuminate\Foundation\Application::version(), so how we fix it, just checking if the method exists before calling it for version check :
Just reporting feedback for commit #3696417
While you updated the support to Laravel 5 and tried to not break the Laravel 4 support, you unfortunately did it, explaining what you did :
But in Laravel 4
$this->app->version()
method doesn't exist at all and will throw a beautifulCall to undefined method Illuminate\Foundation\Application::version()
, so how we fix it, just checking if the method exists before calling it for version check :Please review this PR #78, tested on L5 and L4 as working, also with Travis CI.
The text was updated successfully, but these errors were encountered: