Moved self-update to before_install #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it better to place them both under before_script like https://github.com/thephpleague/skeleton/blob/master/.travis.yml? |
|
No. That skeleton is out of date anyway. |
|
See how they have |
|
Do you know if they are planning to update the skeleton? Or are they abandoning it? |
|
Nobody has time I guess. Like, I'll update my own packages on there, but not other people's. I assume most of the other guys do the same. |
jenssegers
added a commit
that referenced
this pull request
Dec 9, 2015
Moved self-update to before_install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though, I'd actually prefer it to just be removed.