Months and days translated #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anguage files
Rename ago method to diffForHumans, remove timespan method
Move predefined formats to language files
Use Config::get('app.timezone') as default time zone if none was given
|
This should be fixed in the current master version, it does require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, sorry for my bad english.
I have removed nl and tr language files to add new entries in en language file and add fr language file.
The format to explain a relative date should depends from a language, according to me, ie in french '42 minutes ago' become 'there is 42 minutes', the suffix change the place with some language.
I have rename ago method to diffForHumans because some case it returns 'ago', some case 'from now', it's more a difference betwin two dates.
I move predefined formats to language files because there are language dependant
I modify the code to use Config::get('app.timezone') as default time zone if none was given.
Hope this helps.
Regards