Fix changing locale after app has booted #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenssegers thanks for merging. Are you taking part in the #hacktoberfest ? Would you mind labeling the PR? 😄 |
|
@jenssegers also would mind publishing a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty common to have your app change the locale in a middleware. When the app boots up, it's very rare to actually know what the locale will be until the session is booted and locale is set.
This fixes those cases where the locale can be changed at any time after the app has booted.
As a side note, I would recommend to have a proper facade for
Datebecause then you can defer loading of the service provider and translator module every request. Anyway that's for another PR.