add possibility to use translated short notations #229
Conversation
Boschman
force-pushed
the
short-notation-translations
branch
from
8b6a7ce
to
284b322
Compare
| @@ -243,7 +243,16 @@ public function format($format) | |||
|
|
|||
| // Short notations. | |||
| if (in_array($character, ['D', 'M'])) { | |||
| $translated = mb_substr($translated, 0, 3); | |||
| $toTranslate = strtolower($original); | |||
| $sortTranslated = $lang->trans($toTranslate); | |||
Boschman
force-pushed
the
short-notation-translations
branch
from
284b322
to
329e774
Compare
|
Thanks! I just fixed the typo. |
|
@jenssegers, could you please let me know what you think of this pull request? Would you be able to merge the request? Please let me know if you want me to change anything. |
| @@ -243,7 +243,16 @@ public function format($format) | |||
|
|
|||
| // Short notations. | |||
| if (in_array($character, ['D', 'M'])) { | |||
| $translated = mb_substr($translated, 0, 3); | |||
| $toTranslate = strtolower($original); | |||
There was a problem hiding this comment.
I'm more than willing to change this to mb_strtolower, but the original source code uses strtolower as well: https://github.com/jenssegers/date/blob/master/src/Date.php#L241
There was a problem hiding this comment.
I just changed strtolower to mb_strtolower.
Boschman
force-pushed
the
short-notation-translations
branch
from
329e774
to
3e1b771
Compare
* use short notation translations if available * add short notation translations in German and Dutch * update tests
|
Is there anything more I can do to get this pull request accepted? Please let me know, @jenssegers. |
|
@jenssegers Would love to see this pull request accepted. So we can start providing some abbreviated translations too. Apparently what's appearing for an abbreviated Monday in Arabic translates as "However" in Google Translate lol. |
Fix for #226