Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Serbian language (latin script) #232

Merged
merged 5 commits into from
Jan 2, 2017
Merged

Conversation

goksiii
Copy link

@goksiii goksiii commented Dec 26, 2016

Added support for a latin script for the Serbian language.

@jenssegers
Copy link
Owner

jenssegers commented Dec 26, 2016

The filename change will break existing installations though. What are the official language codes for both of these?

@goksiii
Copy link
Author

goksiii commented Dec 26, 2016

For the filename, I have used RFC 5646 (https://tools.ietf.org/html/rfc5646) document. I built filenames for both of these with standardization that is defined in mentioned document. Official language codes for both of these is "sr", by ISO 639-1. In ISO 639-2 document, the language code for the Serbian language may have 2 or 3 characters, "sr" or "srp".
I may add a latin version of Serbian language in this format "srp_Latin". What do you mean about this?

@goksiii
Copy link
Author

goksiii commented Dec 26, 2016

Or I may use "sr_Latin" for the filename for a latin script version of the Serbian language. The filename for Cyrillic script version will stay same.

@goksiii
Copy link
Author

goksiii commented Dec 29, 2016

@jenssegers any information about merging this pull request? are you ok with changes that I made on PR? I need the latin script of Serbian language in my project.

@jenssegers
Copy link
Owner

This page mentions some other possibilities: http://www.lingoes.net/en/translator/langcode.htm

sr-BA	Serbian (Latin) (Bosnia and Herzegovina)
sr-BA	Serbian (Cyrillic) (Bosnia and Herzegovina)
sr-SP	Serbian (Latin) (Serbia and Montenegro)
sr-SP	Serbian (Cyrillic) (Serbia and Montenegro)

Any chance we could use one of these?

@goksiii
Copy link
Author

goksiii commented Dec 29, 2016

@jenssegers
Yes.
Filename of a Cyrillic script will stay same (only "sr.php"), but filename of a Latin script will be "sr-SP.php".

@goksiii
Copy link
Author

goksiii commented Dec 29, 2016

@jenssegers
PR is updated with changes. Can you review again this PR?
Thanks :)

@jenssegers jenssegers merged commit 5d53042 into jenssegers:master Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants