Fix awkward Korean Translation #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekatarnls
suggested changes
May 16, 2018
There was a problem hiding this comment.
Seems swapped unless it's a Google Translate mistake: need inspection.
https://translate.google.com/#ko/en/3%EB%85%84%20%EC%9D%B4%EC%A0%84
https://translate.google.com/#ko/en/3%EB%85%84%20%EC%9D%B4%ED%9B%84
| 'after' => ':time 뒤', | ||
| 'before' => ':time 앞', | ||
| 'after' => ':time 이전', | ||
| 'before' => ':time 이후', |
There was a problem hiding this comment.
@darron1217 after and before seems to be swapped.
This test can fail, because each time you can `Date:now()`, there is no guarantee the timestamp did not change meanwhile.
|
The Travis failure is due to second overlap between |
[Unit tests] Use the same timestamp everywhere
|
Would love to get some additional reviewers on this :) |
Update vi.php
Belarusian localization
|
Oh.. that was my mistake |
Fixed Ukrainian translation for `ago` line.
|
I created clean PR again #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really simple PR :)