Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend\Diactoros\Response\SapiEmitter has been depricated #75

Closed
iamjoshljohnson opened this issue Dec 30, 2019 · 4 comments
Closed

Zend\Diactoros\Response\SapiEmitter has been depricated #75

iamjoshljohnson opened this issue Dec 30, 2019 · 4 comments

Comments

@iamjoshljohnson
Copy link

Zend\HttpHandlerRunner\Emitter\SapiEmitter is the replacement for the deprecated class. As a part of updating this, you will need to remove the use of "zendframework/zend-diactoros": "^1.0 || ^2.0", and update it with "zendframework/zend-httphandlerrunner": "^1.1"

@jmolivas
Copy link
Contributor

jmolivas commented Mar 4, 2020

@jenssegers will you accept a PR with this changes updating the deprecated dependencies? I got a fork with this changes applied.

@jenssegers
Copy link
Owner

Sure thing!

@jmolivas
Copy link
Contributor

jmolivas commented Mar 6, 2020

@jenssegers PR is here #78

CircleCI is complaining when PHP version < 7.1
https://travis-ci.org/jenssegers/php-proxy/jobs/659028737

image

7.0 and even 7.1 are deprecated now, not sure if CircleCI should keep testing those deprecated versions, what do you think?
https://www.php.net/supported-versions.php

jenssegers added a commit that referenced this issue Mar 6, 2020
@jmolivas
Copy link
Contributor

jmolivas commented Apr 7, 2020

PR was merged this should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants