Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make partnershipId more unique #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hollabalo
Copy link

This adds the serviceName as part of the partnershipId generated when importing CPA. Sometimes, some partnerships end up with the same generated partnershipId.

This will prevent missing partnerships from the CPA import.

@base2bot
Copy link
Collaborator

Can one of the admins verify this patch?

@aaronwalker
Copy link
Member

@jmgerona so the problem your having is you have CPA agreements with same CPAId, channel and action?

Good CPA design should generally make action unique per channel and in most cases action unique within the CPA.

I don't have an issue introducing this change will just need to do some testing to verify it doesn't introduce any side affects, which I better sure it should be fine

@hollabalo
Copy link
Author

@aaronwalker Yes, that is the problem that we are having. Also, the CPA is from an actual telco that we are working with now.

At first, we were wondering why we don't get all the partnerships when we import the CPA file. Then we found this, thus making the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants