[#60] CompositionalLayout Enum 정의 + Note #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note
기존 moti의 CompositionalLayout 생성 코드는 많은 파라미터가 있었습니다. (Overview에 쓴 것처럼!)
이 파라미터들은 모두 CompositionalLayout 요소들(item, group, section)의 각 속성이었습니다.
이를 어떻게 하면 줄일 수 있을까 고민했고 각 요소들을 구조체로 정의하는 방법을 떠올렸습니다.
기존 코드를 보면서 어떤 부분이 어떻게 아쉬운지 느끼고 어떤 방향으로 수정할지 결정할 수 있었던 경험이었습니다.
Issue
closed #60