Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to configure locallyDynamic in app/build.gradle.kts #20

Closed
mochadwi opened this issue Jul 1, 2020 · 8 comments
Closed

Unable to configure locallyDynamic in app/build.gradle.kts #20

mochadwi opened this issue Jul 1, 2020 · 8 comments

Comments

@mochadwi
Copy link

mochadwi commented Jul 1, 2020

Description

Thanks for this great plugins!

Testing the AAB without hassle with your library.

I have problems with locallyDynamic unresolved inside app/build.gradle.kts

Steps to Reproduce

LocallyDynamic gradle plugin version

0.2

LocallyDynamic android library version

0.3

LocallyDynamic android studio plugin version

0.5

Android Studio Version

4.0

Link to a public git repo demonstrating the problem:

(company project)

@mochadwi
Copy link
Author

mochadwi commented Jul 1, 2020

@jeppeman

@jeppeman
Copy link
Owner

jeppeman commented Jul 1, 2020

Hi, this is not due to AGP 4.0, but rather incompatibility with kotlin script; I will have a look at the issue

@mochadwi
Copy link
Author

mochadwi commented Jul 1, 2020

apply plugins (using both method): Screen Shot 2020-07-01 at 5 58 51 PM

configure task inside buildType.debug: Screen Shot 2020-07-01 at 5 58 14 PM

Throw this error: Extension of type 'LocallyDynamicExtension' does not exist.

@jeppeman

@mochadwi mochadwi changed the title Is there any estimation of release date for AGP 4.0 support Unable to use locallyDynamic in app/build.gradle.kts Jul 1, 2020
@mochadwi mochadwi changed the title Unable to use locallyDynamic in app/build.gradle.kts Unable to configure locallyDynamic in app/build.gradle.kts Jul 1, 2020
@mochadwi
Copy link
Author

mochadwi commented Jul 1, 2020

Although, I can get rid of the above error with this approach:

                    plugins.withId("...locallydynamic...") {
                        configure<com.jeppeman.locallydynamic.gradle.LocallyDynamicExtension> {
                            enabled = true
                            throttleDownloadBy = 200
                        }
                    }

The above approach referenced from this: gradle/gradle#11338 (comment)

But then throw this error instead:

java.lang.IllegalStateException: com.jeppeman.locallydynamic.generated.LocallyDynamicBuildConfig not found; make sure that the locallydynamic gradle plugin has been properly applied

Does it means, the plugins still not configured properly? @jeppeman

@jeppeman
Copy link
Owner

jeppeman commented Jul 1, 2020

Yes, working on a fix

@jeppeman
Copy link
Owner

jeppeman commented Jul 2, 2020

This should be fixed in version 0.3 of the gradle plugin, although the new version of the Android Studio plugin needs to be approved by Jetbrains first (version 0.6).

Then use as follows from build.gradle.kts:

import com.jeppeman.locallydynamic.gradle.extensions.locallyDynamic

android {   
    buildTypes {
        getByName("debug") {
            locallyDynamic {
                ...
            }
        }
    }
}

@mochadwi
Copy link
Author

mochadwi commented Jul 2, 2020

Thanks for the fix & updates @jeppeman Will be waiting for the jetbrains to approved your plugins :)

@jeppeman
Copy link
Owner

jeppeman commented Jul 3, 2020

👍 AS plugin 0.6 is live now

@jeppeman jeppeman closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants