Fix Python 3 compatibility #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention this was tested with Python 3.7.3rc1 and Ansible dev. |
|
Any change for this to get merged? Python 2 is EOL and we have switched everything to Python 3 on our side. Thanks. |
hhenkel
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
@crayfishx This PR is identical to what I have locally and therefore I guess it should be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use this plugin with Python 3 and had to fix a few minor incompatibilities to make it work.
The
items()call does return a copy instead of a generator in Python 2, but I think that's a fair compromise as the configuration is very unlikely to be large enough to cause a performance issue.The dictionary merge could be written as
{**dict1, **dict2}from Python 3.5 onward, which probably wouldn't be too much of a stretch as prerequisite as this point, but this would also break Python 2 compatibility.