Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#1103: Adding structure rules for subprogram specifications. #1108

Merged
merged 19 commits into from
Jan 27, 2024

Conversation

JHertz5
Copy link
Contributor

@JHertz5 JHertz5 commented Jan 20, 2024

Resolves #1103.
These additions involve new rules, function_019 and procedure_013. They make the rules function_009 and procedure_011 redundant.
This PR is currently a draft, because the unit tests are still being worked on. Ready for review.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23b63eb) 96.54% compared to head (b42eb4b) 96.61%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   96.54%   96.61%   +0.06%     
==========================================
  Files        1540     1546       +6     
  Lines       28930    29111     +181     
==========================================
+ Hits        27930    28125     +195     
+ Misses       1000      986      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JHertz5 JHertz5 marked this pull request as ready for review January 21, 2024 12:03
…te of `multiline_subprogram_specification_structure` rules to `add_new_line`
…ine_subprogram_specification_structure class to be a string instead of a non-existent variable.
…te of `multiline_subprogram_specification_structure` rules to `ignore`.
Copy link
Owner

@jeremiah-c-leary jeremiah-c-leary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I have this process down yet, but...

I commented on the default values for the new rules and I will add a diagram for the documentation.

--Jeremy

@jeremiah-c-leary jeremiah-c-leary merged commit 51a95c2 into jeremiah-c-leary:master Jan 27, 2024
6 of 7 checks passed
@JHertz5 JHertz5 deleted the issue-1103 branch January 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rules for function and parameter to have the closing parenthesis on its own line
2 participants