Setting limit throws IllegalFormatConversionException #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, setting the limit parameter throws the following exception: ``` java.util.IllegalFormatConversionException: d != java.lang.String at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4045) at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2748) at java.util.Formatter$FormatSpecifier.print(Formatter.java:2702) at java.util.Formatter.format(Formatter.java:2488) at java.util.Formatter.format(Formatter.java:2423) at java.lang.String.format(String.java:2834) at fr.dudie.nominatim.client.request.QueryParameterAnnotationHandler.process(QueryParameterAnnotationHandler.java:97) at fr.dudie.nominatim.client.request.NominatimRequest.getQueryString(NominatimRequest.java:47) at fr.dudie.nominatim.client.JsonNominatimClient.search(JsonNominatimClient.java:188) ``` The issue is that the following line of code ```String paramValue = serialize(paramMetadata, fieldValue, f.getName());``` in ```QueryParameterAnnotationHandler.process(final Object o) (line 88)``` method converts the value of limit parameter from Integer to String. However when you try to format the value as it is done in ```String.format(Locale.US, paramFormat, paramValue)``` in ```QueryParameterAnnotationHandler.process(final Object o) (line 97)```, it uses the %d formatter for limit specified in ```QueryParmeter```. For instance if you set the limit to 3, the following code is executed ```String.format(Locale.US, "%d", "3")``` which results in the above exception.
|
You're right, Thank you |
jeremiehuchet
pushed a commit
that referenced
this pull request
Jan 18, 2015
Setting limit throws IllegalFormatConversionException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, setting the limit parameter throws the following exception:
The issue is that the following line of code
String paramValue = serialize(paramMetadata, fieldValue, f.getName());inQueryParameterAnnotationHandler.process(final Object o) (line 88)method converts the value of limit parameter from Integer to String.However when you try to format the value as it is done in
String.format(Locale.US, paramFormat, paramValue)inQueryParameterAnnotationHandler.process(final Object o) (line 97), it uses the %d formatter for limit specified inQueryParmeter. For instance if you set the limit to 3, the following code is executedString.format(Locale.US, "%d", "3")which results in the above exception.