Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add junos_interfaces_logical_present #641

Closed
lotusnoir opened this issue Mar 21, 2024 · 1 comment · Fixed by #649
Closed

Feature request: add junos_interfaces_logical_present #641

lotusnoir opened this issue Mar 21, 2024 · 1 comment · Fixed by #649
Assignees
@jeremmfr
Labels
enhancement New feature or request
Milestone
v2.7.0

Comments

@lotusnoir
Copy link

Hello,

Im currently trying to get a dynamic list of all security zones associated with each of the vsrx i have.
I saw that in the data ressources there is the junos_interfaces_physical_present that return all interfaces:
Is it possible to create the same one for the logical ones ?

Thanks in advance
@lotusnoir lotusnoir added the enhancement New feature or request label Mar 21, 2024
@jeremmfr
Copy link
Owner

jeremmfr commented Apr 3, 2024

Hi 👋

Thank you for raising this issue. Considering logical interfaces are under each parent physical interface when reading interfaces, instead of adding a new data-source, adding the data to the existing interfaces_physical_present data-source is more desirable.

I will take care of adding this.

@jeremmfr jeremmfr added this to the v2.7.0 milestone Apr 3, 2024
@jeremmfr jeremmfr self-assigned this Apr 3, 2024
jeremmfr added a commit that referenced this issue Apr 5, 2024
@jeremmfr
d/interfaces_physical_present: add interfaces block map attribute
bed41f5 
with same attributes as interface_statuses and additional logical_interface_names attribute
deprecate interface_statuses attribute (read the interfaces attribute instead)
Fix #641
@jeremmfr jeremmfr mentioned this issue Apr 5, 2024
Merged
@jeremmfr jeremmfr mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremmfr jeremmfr

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging a pull request may close this issue.

d/interfaces_physical_present: add interfaces block map attribute jeremmfr/terraform-provider-junos
2 participants
@jeremmfr @lotusnoir