Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-msg is not activated with mu4e-compose-reply #153

Open
baracunatana opened this issue Jul 1, 2022 · 17 comments
Open

org-msg is not activated with mu4e-compose-reply #153

baracunatana opened this issue Jul 1, 2022 · 17 comments

Comments

@baracunatana
Copy link

Hi everyone.

I have the same issue as #87 after updating my pc (it was working fine two days agoTM). Composing a new email (with mu4e-compose-new) works as intended, but mu4e-compose-reply doesn't activate org-msg (however, org-msg-mode evaluates to t in the reply buffer). I can call org-msg-edit-mode and it kind of works (I can use org to edit my message), but it doesn't add my signature and the original message is displayed whit > and not with the outlook style.

I tried going to the previous commit or org-msg (77f5911) but it didn't work.

I have mu4e 1.8.1, org-msg 4.0 and emacs 29.05. I also set mail-user-agent to 'mu4e-user-agent in my config file.

Any help is appreciated.

@Phundrak
Copy link

Phundrak commented Jul 3, 2022

I have the same issue, but with some differences:

  • If I load mu4e before org-mode, org-msg isn’t loaded at all and org-msg-mode evaluates to nil in the reply buffer
  • If I load org-mode, then org-msg is loaded correctly and works as expected

For the record, here are the relevant software versions:

  • mu & mu4e 1.8.1 (installed from the AUR on Arch Linux)
  • org-msg 4.0 (commit 60e22e4, master’s HEAD at the time of this message)
  • Emacs 29.0.50 (commit emacs-mirror/emacs@1dc70544d8)

Here is my relevant org-msg configuration (stripped of a few lines, full version available here):

(use-package org-msg
  :after (org mu4e)
  :straight (:build t)
  :hook ((mu4e-compose-pre . org-msg-mode))
  :config
  (setq org-msg-default-alternatives '((new           . (text html))
                                       (reply-to-html . (text html))
                                       (reply-to-text . (text)))))

@baracunatana
Copy link
Author

@Phundrak Thanks for the help. I tried your customization for org-msg-default-alternatives and org-msg is now launched when replying to a message. However, it isn't converting the citation to outlook format (i.e. I still have the > citation style). Also, the signature is added after the citation. I have org-msg-convert-citation set to t, but still no luck. Do you have the same issue?

@Phundrak
Copy link

Phundrak commented Jul 5, 2022 via email

@baracunatana
Copy link
Author

I can confirm that going back to mu4e 1.6.10 (from 1.8.1) solves the issue. It seems that recent changes in mu4e interfered with org-msg in some way.

@baracunatana
Copy link
Author

I still have the issue of org-msg not firing up if org-mode is not loaded on my side.

What if you configure it with only :after (mu4e)

@Phundrak
Copy link

Phundrak commented Jul 6, 2022 via email

Phundrak added a commit to Phundrak/config.phundrak.com that referenced this issue Jul 6, 2022
@benthamite
Copy link

I also started experiencing this issue after upgrading to the latest version of mu4e (1.8.5). @baracunatana, where you able to identify the cause of the problem, or are you still using an earlier version of mu4e?

@baracunatana
Copy link
Author

@benthamite My debugging skill are not up to this challenge, so I just went back to mu 1.6.10 and it works perfectlly now.

@ifinkelstein
Copy link

ifinkelstein commented Jul 12, 2022

Also having the same problem when composing replies with mu/mu4e 1.8.5. Will watch this issue to see if there's a resolution.

@benthamite
Copy link

I confirm that downgrading to 1.6.11 solved the issue for me. FYI, here's the mu 1.6.11 homebrew formula. To downgrade with brew, save the file, then

  1. $ brew uninstall mu
  2. $ brew install /path/to/mu.rb
  3. $ brew pin mu

@bergheim
Copy link

bergheim commented Sep 2, 2022

@Phundrak is this still working for you? I tried to apply your config, but I still get the ">" quotation. org syntax works, however.

@tizero
Copy link

tizero commented Sep 10, 2022

My guess: under mu 1.8.* I cannot retrieve the fields :body-txt or :body-html from message property list anymore. Expressions like (mu4e-message-field msg :body-html) (as in org-msg-article-htmlp-mu4e) evaluate to nil and org-msg selects the reply-to-text alternative in every case.

@cnoceda
Copy link

cnoceda commented Sep 21, 2022

My guess: under mu 1.8.* I cannot retrieve the fields :body-txt or :body-html from message property list anymore. Expressions like (mu4e-message-field msg :body-html) (as in org-msg-article-htmlp-mu4e) evaluate to nil and org-msg selects the reply-to-text alternative in every case.

I've the same issue. I check mu4e-message-field and it's return nil as you say.

@david-alvarez-rosa
Copy link

Could djcb/mu#2337 be related?

@Phundrak
Copy link

Phundrak commented Oct 11, 2022 via email

@bergheim
Copy link

bergheim commented Oct 28, 2022

I don't think so @david-alvarez-rosa - this has always been like this for me.

I still cannot get org-msg to work the way it did. Replies will be text only.

Also, as @Phundrak mentions as well, org-msg-convert-citation has never worked for me either.

If I force HTML, things still work fine, so I guess it is related to :body-html not being part of the message anymore. If I do this:

        org-msg-default-alternatives '((new               (html))
                                       (reply-to-html	. (html))
                                       (reply-to-text	. (html)))

I get the correct reply, but then everything will be an HTML reply.

@gajama
Copy link
Contributor

gajama commented Dec 1, 2022

I've put in a PR that I think fixes the mu4e issues: #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants