Allow fancy html5 ARTICLE tag in export #10
Conversation
jeremy-compostella
changed the title
article tag in export
| @@ -617,7 +618,7 @@ absolute paths." | |||
| (if (not original) | |||
| (assq-delete-all 'script (assq 'head reply)) | |||
| (org-msg-improve-reply-header original css) | |||
| (push (assq 'div (assq 'body reply)) (cddr (assq 'body original)))) | |||
| (push (assq 'reply-element (assq 'body reply)) (cddr (assq 'body original)))) | |||
There was a problem hiding this comment.
It should not work. You are using the symbol 'reply-element instead of the reply-element variable value (which should be either 'article or 'div).
The correct syntax is:
(push (assq reply-element (assq 'body reply)) (cddr (assq 'body original))))
There was a problem hiding this comment.
Since this is used in only one location, you could also:
(push (assq (if 'org-html-html5-fancy 'article 'div) (assq 'body reply))
(cddr (assq 'body original))))
There was a problem hiding this comment.
oops, I screwed up my git history & hand-typed that. Yes, of course that's wrong as written.
would you rather have the second version? happy to switch. will update the commit message on the change.
There was a problem hiding this comment.
Actually your patch was still broken because of an extra ' that I did not noticed.
I fixed it and pushed it. Let me know if it resolves your issue.
|
so we can close this now, right? thx. for pushing the fix. |
dynamically set the element we are searching for in the reply tree depending on value of
org-html-html5-fancy.fixes #8