ZMQSocket: -close: Fix crash when called twice. (NOT THREADSAFE)

jeremy-w · Jan 9, 2011 · db51b6b · db51b6b
1 parent 0e01e0b
commit db51b6b
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/ZMQSocket.m b/src/ZMQSocket.m
@@ -48,12 +48,15 @@ - (id)initWithContext:(ZMQContext *)context_ type:(ZMQSocketType)type_ {
 @synthesize socket;
 @synthesize closed;
 - (void)close {
-	int err = zmq_close(self.socket);
+	// FIXME: This is not thread-safe.
-	if (err) {
+	if (!self.closed) {
-		ZMQLogError(self, @"zmq_close");
+		int err = zmq_close(self.socket);
-		return;
+		if (err) {
+			ZMQLogError(self, @"zmq_close");
+			return;
+		}
+		self.closed = YES;
 	}
-	self.closed = YES;
 }
 
 - (void)dealloc {