Improved OIDC Discovery #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually seeing #6, should we enable the other grant types automatically when you enable Implicit Grant using the same code as you listed in that issue? After that we can re-add them to discovery. |
|
Okay, not proud of how many commits that took and sorry for the spam, but I am done with this PR. Hopefully it is a bit more spec compliant now, helping everyone! Thank you in advance for your time checking this. |
|
Hey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the discovery document to be correct.
We only support
codeandtokenforgrant_types_supported, as this library only supportsAuth Code Flowby default and does not add the Implicit Flow and Hybrid Flow grant types (https://openid.net/specs/openid-connect-core-1_0.html#Authentication)Sorry for the second PR so soon, did not expect you to create a release so fast ;)
Luckily this one can be a patch to 2.2.1 as everything is optional and there is no backwards incompatibility. Default behaviour for scopes is the same.