Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content overflows the container if HeaderComponent is set #4

Closed
OmgDef opened this issue Dec 5, 2018 · 2 comments
Closed

Content overflows the container if HeaderComponent is set #4

OmgDef opened this issue Dec 5, 2018 · 2 comments

Comments

@OmgDef
Copy link
Contributor

OmgDef commented Dec 5, 2018

This happens because onScrollViewChange is called before the header height is calculated.

simulator screen shot - iphone x - 2018-12-05 at 23 11 51
@jeremybarbet
Copy link
Owner

Yes you are right, it's already on my todo list, feel free to open a pull request if you already have a fix in mind

jeremybarbet added a commit that referenced this issue Dec 10, 2018
@jeremybarbet
Merge pull request #6 from OmgDef/master
570bb81 
Issue #4 fix. Header height caluculation.
@jeremybarbet
Copy link
Owner

Should be good now 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremybarbet @OmgDef