+ Allow building client with custom reqwest::ClientBuilder #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesGuthrie Ho, this PR is clean and nicely done. Let me think more if no downside, but looks very good. |
|
@jeremychone Thanks! The only reservation I have is that it might make sense to use a builder instead of multiple different functions. |
|
@JamesGuthrie Merged it. Since this library revolves around Reqwest and Reqwest has its own builder, I think it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to configure the underlying Reqwest instance, which is not possible in the current setup.
This PR adds the
new_client_with_reqwestfunction to allow passing in areqwest::ClientBuilderinstance which has been customised.