chore: Remove MacOS support #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
We talked about this on Discord. @lstebner has an active Apple Developer account we can use (🙏) to sign the MacOS binaries, so we can consider broken MacOS auto-updates to be a bug with a fix. #336 has been opened to address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes MacOS app support. This is being done because Electron Builder (the toolchain we are using to generate native apps) cannot enable app auto-updating without code signing:
Additionally:
How this change can be validated
We'll have to run a release and ensure that the "Release New Version" workflow succeeds without generating MacOS artifacts.
Questions or concerns about this change
This is a bummer of a change, but I think it's important to keep Farmhand fully operational with zero costs. That can't be achieved with MacOS, so unfortunately we won't be able to serve those players as well as those on other platforms. The good news is that Farmhand can be installed as a PWA on any platform, and that will provide a native app experience for all!