feat: [closes #369] add sweet potato #372
Conversation
- new crop: sweet potato - new recipe: sweet potato pie - new recipe: sweet potato fries
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Great work @lstebner! I love the art for all the new items. There are a few very minor things I saw that are worth addressing, but also I noticed that a stray sweet-potato-growing (1).png file was committed. I can't comment inline for image files, but that should probably be removed before merging this.
src/data/levels.js
Outdated
| @@ -85,6 +85,10 @@ levels[34] = { | |||
| unlocksShopItem: items.garlicSeed.id, | |||
| } | |||
|
|
|||
| levels[35] = { | |||
There was a problem hiding this comment.
I'd like to keep crop unlock levels two apart to keep the game challenging and increase the challenged a bit. Would you be okay with moving this to level 36?
| levels[35] = { | |
| levels[36] = { |
| @@ -65,6 +66,7 @@ export const cropIdToTypeMap = { | |||
| [SOYBEAN]: 'soybean', | |||
| [SPINACH]: 'spinach', | |||
| [STRAWBERRY]: 'strawberry', | |||
| [SWEET_POTATO]: 'sweet-potato', | |||
There was a problem hiding this comment.
This is a total aside not at all related to this PR (and not a request for a change), but I'd love to redesign the crop definition system a bit so there aren't so many touch points for adding crops. It's kind of laborious to add new crops, and I think we could have something a little more streamlined.
| id: 'sweet-potato-fries', | ||
| name: 'Sweet Potato Fries', | ||
| ingredients: { | ||
| [items.sweetPotato.id]: 10, |
There was a problem hiding this comment.
I wish we had an oil item to use as an ingredient here. It's probably something worth adding to the backlog, so I can take care of that soon!
There was a problem hiding this comment.
Feature request filed as #373.
src/img/items/sweet-potato.piskel
Outdated
| @@ -0,0 +1 @@ | |||
| {"modelVersion":2,"piskel":{"name":"New Piskel","description":"","fps":12,"height":24,"width":24,"layers":["{\"name\":\"Layer 1\",\"opacity\":1,\"frameCount\":1,\"chunks\":[{\"layout\":[[0]],\"base64PNG\":\"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAA7UlEQVRIS2NkoDFgpLH5DKMWEAxhioMoyoD3P7otyy58hptLlgXIhjYHaYLNv3rnMoO2ii6YXbvuOgPMEpIsgBkMMxRX+JBsAbEGwywkyQKQ4bhcDAoWGIAFD0lBhM1wXIYiBxdRPsBlOLJLKYoDdAuQUwmhxE/QB8QYjmwhriQKcghGMiXGcHw+QHY9hgUww3EFB6FgQjccxQKQ4Z0FaQy/Hh0mFMRY5bEZTpEF6L4hyQJ0zfiCBmQwCCAXcMheRIlkfLkWW7jgcjVOC0AS2EpK9FwK4+NyNV4LkCUJlfXEpAaSimtiDERXQ3MLANJApBnOiL6/AAAAAElFTkSuQmCC\"}]}"]}} | |||
There was a problem hiding this comment.
This has "name":"New Piskel", and it looks like it should be "name":"sweet-potato".
|
I just pushed d57f5d1, which gives Vegetable Oil slightly more definition against the background:
|
There was a problem hiding this comment.
Excellent work @lstebner! This is some great-looking art and it helps to fill out our content a lot more. LGTM!
What this PR does
adds sweet potato crop, sweet potato pie recipe, and sweet potato fries recipes. also adds vegetable oil, onion rings, and fried tofu
How this change can be validated
sweet potato is a high level crop so need to get enough sales to be level 35 or higher. to unlock the recipes you need sales of at least 100 sweet potatoes for fries, and 200+ for the pie along with 250 wheat and 75 butter (same as pumpkin pie).
you can do this legitimately or enter this in the console (the 120,000 pumpkins are just to get to level 35):
sell any one item through the UI after doing that to trigger the recipe logic and unlock the recipes.
Questions or concerns about this change
As usual I am open to any suggestions/improvements to the art, ingredients, crop tier, growing schedule, etc.
Additional information
note: sweet potato is not grown from seeds, but it is grown from rooted segments called "slips".