feat(Cellar): Show purchase notification #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeremyckahn
commented
Jun 17, 2023
Comment on lines
-32
to
-66
| test('notification is shown when cow pen is purchased', async () => { | ||
| const loadedState = saveDataStubFactory({ | ||
| money: 1500, | ||
| }) | ||
|
|
||
| await farmhandStub({ | ||
| localforage: { | ||
| getItem: () => Promise.resolve(loadedState), | ||
| setItem: (_key, data) => Promise.resolve(data), | ||
| }, | ||
| }) | ||
|
|
||
| await nextView() | ||
| const upgradesTab = screen.getByText('Upgrades') | ||
| userEvent.click(upgradesTab) | ||
|
|
||
| const cowPenContainer = screen | ||
| .getByText('Buy cow pen') | ||
| .closest('.TierPurchase') | ||
|
|
||
| // Open the list of cow pen options | ||
| userEvent.click(within(cowPenContainer).getAllByRole('button')[1]) | ||
|
|
||
| userEvent.click(screen.getByRole('option', { name: '$1,500: 10 cow pen' })) | ||
|
|
||
| // Make the purchase | ||
| userEvent.click(within(cowPenContainer).getAllByRole('button')[0]) | ||
|
|
||
| const notification = await screen.findByRole('alert') | ||
| expect( | ||
| within(notification).getByText( | ||
| 'Purchased a cow pen with capacity for 10 cows! You can visit your cow pen by going to the "Cows" page.' | ||
| ) | ||
| ).toBeInTheDocument() | ||
| }) |
There was a problem hiding this comment.
This is effectively covered by this new test, which is much simpler and more lightweight:
farmhand/src/game-logic/reducers/purchaseCowPen.test.js
Lines 27 to 35 in 73056d8
lstebner
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR shows a notification to the player when a cellar is purchased.
This PR also refactors how cow pen notifications are shown and improves some type definitions.
How this change can be validated
Purchase a cellar and verify that a notification is shown.
Additional information