fix(utils): [closes #430] Make findInField return the correct plot
#431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeremyckahn
commented
Aug 16, 2023
| * @returns {?farmhand.plotContent} | ||
| */ | ||
| (field, condition) => { | ||
| const [plot = null] = |
There was a problem hiding this comment.
The root cause of the bug is that this is always returning the first plot in the row.
There was a problem hiding this comment.
ohhh, wow good find. i didn't even notice this syntax when i was looking yesterday
There was a problem hiding this comment.
Yeah... that's what I get for being clever. 🤦
The new version is much less clever and more straightforward, I think!
lstebner
approved these changes
Aug 16, 2023
| * @returns {?farmhand.plotContent} | ||
| */ | ||
| (field, condition) => { | ||
| const [plot = null] = |
There was a problem hiding this comment.
ohhh, wow good find. i didn't even notice this syntax when i was looking yesterday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
For #430, this PR fixes an implementation bug that manifested in Scarecrows not working if they weren't the first plot in a Field row.
How this change can be validated
Place a Scarecrow somewhere in the middle of the Field and ensure that crows do not attack when ending the day.
Additional information
It seems that this bug may have been introduced here: https://github.com/jeremyckahn/farmhand/pull/427/files#diff-ebd8554ec43b07366bd40d16b09d1d063d9e8d5921fa30de4eb80bffdf82668dR718-R727
In any case, this issue wasn't noticed until #427 was shipped.