Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 breaking seek #77

Closed
SBoudrias opened this issue Apr 24, 2015 · 5 comments
Closed

1.4 breaking seek #77

SBoudrias opened this issue Apr 24, 2015 · 5 comments

Comments

@SBoudrias
Copy link
Contributor

Looks like the 1.4 release is breaking seek. Not sure what changed, and I haven't investigated the issue yet.

@jeremyckahn
Copy link
Owner

Yikes! Sorry about that. The unit tests are still passing, so that's a little surprising. Do you have a test case that reproduces the issue?

@jeremyckahn
Copy link
Owner

If you don't have one, don't worry about it — I should have some time tomorrow to get to the bottom of this.

@SBoudrias
Copy link
Contributor Author

I don't have a reduced test case, but I can point you where the bug is.

It's these lines, since the code changed to do a check on the timestamp, the value of normalizedPosition is always 0 when it's triggered from a seek call.

@jeremyckahn
Copy link
Owner

Got it. It must be something to do with the recent "delay" functionality. I'll bet this can be demonstrated with a unit test that utilizes both the delay functionality as well as seek.

@jeremyckahn
Copy link
Owner

I just pushed and released a fix(1.4.2). Careless mistake on my part. Sorry about that. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants